Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CRITICAL) Wrong key derivation for specific mnemonics, BIP39/BIP44 issue? #5667

Closed
a49q258k opened this issue Feb 23, 2017 · 3 comments
Closed

Comments

@a49q258k
Copy link

a49q258k commented Feb 23, 2017

TEST CASE:

Mnemonic fruit wave dwarf banana earth journey tattoo true farm silk olive fence
Passphrase banana

BitPay
m/44'/0'/0'/0/0 13EuKhffWkBE2KUwcbkbELZb1MpzbimJ3Y

Electrum, iancoleman.github.io/BIP39/
m/44'/0'/0'/0/0 17rxURoF96VhmkcEGCj5LNQkmN9HVhWb7F

Also see iancoleman/bip39#58, I am not sure which clients are deriving properly / improperly, but we have a BIP39 mnemonic and passphrase that derives different addresses on different clients

@slush0 @prusnak

@prusnak
Copy link

prusnak commented Feb 23, 2017 via email

@prusnak
Copy link

prusnak commented Apr 24, 2018

@BGalliotti care to explain why you closed the issue?

@BGalliotti
Copy link

@prusnak Sorry, I tracked the pull request you mentioned and I ended up in this merged PR (bitpay/bitcore-lib#116 (comment)) and this comment (bitpay/bitcore-lib#116 (comment)) that has a similar example as above working good. Could you tell me what's the issue here? Anyway, I will contact the wallet team today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants