Skip transaction size check during replay

[abitmore]

User Story
Skipping the transaction size check may (or may not) bring us better performance on replay.

Currently we have this code (introduced by #1586):

bitshares-core/libraries/chain/db_block.cpp

Lines 660 to 662 in 81de0c5

	FC_ASSERT( head_block_time() <= HARDFORK_CORE_1573_TIME
	|| trx.get_packed_size() <= chain_parameters.maximum_transaction_size,
	"Transaction exceeds maximum transaction size." );

and we have similar code like this:

bitshares-core/libraries/chain/db_block.cpp

Lines 536 to 539 in 81de0c5

	if( !(skip & skip_block_size_check) )
	{
	FC_ASSERT( fc::raw::pack_size(next_block) <= get_global_properties().parameters.maximum_block_size );
	}

(I thought I've submitted this somewhere else but did not find it so far. Please close if it's duplicate.)

Impacts
Describe which portion(s) of BitShares Core may be impacted by your request. Please tick at least one box.

• API (the application programming interface)
• Build (the build process or something prior to compiled code)
• CLI (the command line wallet)
• Deployment (the deployment process after building such as Docker, Travis, etc.)
• DEX (the Decentralized EXchange, market engine, etc.)
• P2P (the peer-to-peer network for transaction/block propagation)
• Performance (system or user efficiency, etc.)
• Protocol (the blockchain logic, consensus, validation, etc.)
• Security (the security of system or user data, etc.)
• UX (the User Experience)
• Other (please add below)

Additional Context (optional)
Add any other context about your request here.

CORE TEAM TASK LIST

• Evaluate / Prioritize Feature Request
• Refine User Stories / Requirements
• Define Test Cases
• Design / Develop Solution
• Perform QA/Testing
• Update Documentation

[jmjatlanta]

Note: The actual size calculation happens in parallel. So the skip logic would need to be around here too:

bitshares-core/libraries/chain/db_block.cpp

Line 755 in 81de0c5

trx->get_packed_size();

[ryanRfox]

Thanks for assigning yourself @jmjatlanta That helps me know someone will be working it. May I also request you add it to the proper Project Board (Feature or Protocol Upgrade)? It will go into To do by default. You may move it In development when you begin.

[jmjatlanta]

Fixed by PR #1716