Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notify_changed_objects should rethrow when caught a plugin_exception #2241

Closed
17 tasks
abitmore opened this issue Aug 22, 2020 · 1 comment · Fixed by #2242
Closed
17 tasks

notify_changed_objects should rethrow when caught a plugin_exception #2241

abitmore opened this issue Aug 22, 2020 · 1 comment · Fixed by #2242
Assignees

Comments

@abitmore
Copy link
Member

Bug Description

plugin_exception is designed to be handled when pushing a block:

catch( const graphene::chain::plugin_exception& e ) \
{ \
elog( "Caught plugin exception: ${e}", ("e", e.to_detail_string() ) ); \
throw; \
} \

Functions like notify_applied_block() and etc behavior correctly

void database::notify_applied_block( const signed_block& block )
{
GRAPHENE_TRY_NOTIFY( applied_block, block )
}

But notify_changed_objects() silently captures and drops the exception:

} FC_CAPTURE_AND_LOG( (0) ) }

Impacts
Describe which portion(s) of BitShares Core may be impacted by this bug. Please tick at least one box.

  • API (the application programming interface)
  • Build (the build process or something prior to compiled code)
  • CLI (the command line wallet)
  • Deployment (the deployment process after building such as Docker, Travis, etc.)
  • DEX (the Decentralized EXchange, market engine, etc.)
  • P2P (the peer-to-peer network for transaction/block propagation)
  • Performance (system or user efficiency, etc.)
  • Protocol (the blockchain logic, consensus, validation, etc.)
  • Security (the security of system or user data, etc.)
  • UX (the User Experience)
  • Other (please add below)

CORE TEAM TASK LIST

  • Evaluate / Prioritize Bug Report
  • Refine User Stories / Requirements
  • Define Test Cases
  • Design / Develop Solution
  • Perform QA/Testing
  • Update Documentation
@abitmore abitmore added this to the 4.1.0 - Feature Release milestone Aug 22, 2020
@abitmore abitmore self-assigned this Aug 22, 2020
@abitmore abitmore linked a pull request Aug 23, 2020 that will close this issue
@abitmore
Copy link
Member Author

Fixed by #2242.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant