From 40c23806c22474c5b368100f89cebe3c034cff7e Mon Sep 17 00:00:00 2001 From: EmilioLaiso Date: Fri, 14 Jul 2023 17:03:57 +0200 Subject: [PATCH 1/4] rkyv use `default-features = false` --- Cargo.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Cargo.toml b/Cargo.toml index 6f58210c..73865543 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -47,7 +47,7 @@ bytemuck = { version = "1.9", optional = true, default-features = false } mint = { version = "0.5.8", optional = true, default-features = false } rand = { version = "0.8", optional = true, default-features = false } serde = { version = "1.0", optional = true, default-features = false } -rkyv = { version = "0.7", optional = true } +rkyv = { version = "0.7", optional = true, default-features = false } bytecheck = { version = "0.6", optional = true, default-features = false} libm = { version = "0.2", optional = true, default-features = false} From ffa853b232edef3f64d4c1be9d87a84145ef8736 Mon Sep 17 00:00:00 2001 From: EmilioLaiso Date: Fri, 14 Jul 2023 17:39:08 +0200 Subject: [PATCH 2/4] add to dev-dependencies --- Cargo.toml | 1 + 1 file changed, 1 insertion(+) diff --git a/Cargo.toml b/Cargo.toml index 73865543..365714b7 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -54,6 +54,7 @@ libm = { version = "0.2", optional = true, default-features = false} [dev-dependencies] # rand_xoshiro is required for tests if rand is enabled rand_xoshiro = "0.6" +rkyv = "0.7" serde_json = "1.0" [target.'cfg(not(target_arch = "wasm32"))'.dev-dependencies] From 5ccc681e8052c60c09c5fd0c75cdffea37e81b48 Mon Sep 17 00:00:00 2001 From: Marijn Suijten Date: Fri, 14 Jul 2023 17:47:48 +0200 Subject: [PATCH 3/4] Enable `rkyv`'s `size_32` feature for `dev-dependencies` So that when building `--all-features` (turns on `rkyv`) `--all-targets` (builds `benches` etc), there is no error that at least one `size_xx` must be set. --- Cargo.toml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Cargo.toml b/Cargo.toml index 365714b7..5fa45a9d 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -48,13 +48,14 @@ mint = { version = "0.5.8", optional = true, default-features = false } rand = { version = "0.8", optional = true, default-features = false } serde = { version = "1.0", optional = true, default-features = false } rkyv = { version = "0.7", optional = true, default-features = false } -bytecheck = { version = "0.6", optional = true, default-features = false} +bytecheck = { version = "0.6", optional = true, default-features = false } libm = { version = "0.2", optional = true, default-features = false} [dev-dependencies] # rand_xoshiro is required for tests if rand is enabled rand_xoshiro = "0.6" -rkyv = "0.7" +# Set a size_xx feature so that this crate compiles properly with --all-targets --all-features +rkyv = { version = "0.7", features = ["size_32"] } serde_json = "1.0" [target.'cfg(not(target_arch = "wasm32"))'.dev-dependencies] From 102538fd95829a710fe42efbcbd02fcf931c201b Mon Sep 17 00:00:00 2001 From: Marijn Suijten Date: Sat, 22 Jul 2023 10:49:36 +0200 Subject: [PATCH 4/4] CI: Enable `rkyv/size_32` in `cargo doc` build-test --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 8849d27b..1991595a 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -29,7 +29,7 @@ jobs: - name: Build-test documentation env: RUSTDOCFLAGS: -Dwarnings - run: cargo doc --all --all-features --no-deps --document-private-items + run: cargo doc --all --all-features --no-deps --document-private-items --features rkyv/size_32 test: name: Test