Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus issue on email/master password fields on login page #3800

Closed
warwickmm opened this issue Oct 15, 2022 · 7 comments
Closed

Focus issue on email/master password fields on login page #3800

warwickmm opened this issue Oct 15, 2022 · 7 comments
Labels
browser Browser Extension bug web

Comments

@warwickmm
Copy link

warwickmm commented Oct 15, 2022

Steps To Reproduce

  1. Log out of the vault
  2. Attempt to log in by either clicking on the Bitwarden icon and then "Log in", or hitting ctrl+shift+L and then selecting "Log in"
  3. The master password field is not focused, even after waiting for a long time.

Expected Result

The master password field should be given focus so that the user can just begin typing their password.

Actual Result

The master password field is not focused, even after waiting for along period of time. This behavior is similar to that reported in #3787 and #3685, but different than that reported in #3562, which indicates that focus is given after a brief lag.

Screenshots or Videos

No response

Additional Context

No response

Operating System

Linux

Operating System Version

6.0.1-arch2-1

Web Browser

Brave

Browser Version

Version 1.44.112 Chromium: 106.0.5249.119 (Official Build) (64-bit)

Build Version

2022.10.0

@warwickmm warwickmm added browser Browser Extension bug labels Oct 15, 2022
@sadreck
Copy link

sadreck commented Oct 16, 2022

The same behaviour can be observed when visiting https://vault.bitwarden.com (with no browser extension installed) - no fields are autofocused.

Before the most recent update if the username was saved it'd autofocus on the password, which no longer happens.

I'm using Firefox on Win10.

@warwickmm
Copy link
Author

It appears that if the vault is locked, then the password field is focused when attempting to unlock it.

However, if I am logged out of the vault, then the password field is not focused when attempting to log in.

@djsmith85 djsmith85 changed the title Browser extension doesn't give master password field focus Focus issue on email/master password fields on login page Oct 18, 2022
@djsmith85 djsmith85 added the web label Oct 18, 2022
@leglock
Copy link

leglock commented Oct 20, 2022

I am experiencing this issue also on version 2022.10.0 in Firefox 105.0.3 (64-bit) on Windows 11 22621.674. No matter how long I wait, the input never gains focus - I have to manually tab a few times or click it with the mouse.

@sir-pinecone
Copy link

I did some git bisecting and determined that this breaks in #3424 (commit 2357957c). I'm going to try and find the cause, but I'm new to this codebase and this might take a while. If anyone else wants to fix it, go for it!

@sir-pinecone
Copy link

@djsmith85 djsmith85 linked a pull request Nov 3, 2022 that will close this issue
@djsmith85
Copy link
Contributor

With the upcoming release (2022.11) some changes were made to the login-pages and login-flows. During this work, this issue got addressed across clients.

Kudos to @sir-pinecone and @max-programming for offering their help and providing PRs.

Closing this now.

@warwickmm
Copy link
Author

warwickmm commented Dec 15, 2022

@djsmith85 , with version 2022.12.0 if the email is auto-filled one still has to tab over to "continue" to proceed to the master password page. Is it possible for the continue button to be focused so that one can just hit enter to navigate to the master password page? Or is there an option to skip the username page if I only have one known username?

Previously, one just needed to hit ctrl+shift+L and start typing their master password. With the past few releases, there are more obstacles that one has to navigate through.

This is using the browser extension with Brave Version 1.46.140 Chromium: 108.0.5359.99 (Official Build) (64-bit).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser Browser Extension bug web
Projects
None yet
5 participants