-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Motion to rename "WindowedApp" to "GraphicalApp" #418
Comments
Ok, I made #419 as a WIP PR. |
cc @rhoot for 2nd opinion... |
While I agree with the sentiment ( |
Btw, just to clarify this. Using "vs*" means in VS IDE & VS build system (in the same way as gmake means make, not GCC), it doesn't imply compiler. In bx toolchain you can see that you can specify |
Are you trying to have one application that could be compiled as ConsoleApp or WindowedApp by using some configuration option? Not quite clear what you're trying to achieve. And I never seen need to do any configuration based on type of app that might change. Usually it's one or another, and then you just apply settings that are appropriate. |
I had a few places where |
Ideally GENie would have something like: operating system / compiler / arch / cpu / crt / build system / IDE, and then you would be able to filter based on any of those. |
Sounds like a feasible idea. Maybe for genie2? As these changes would be breaking backwards compatibility. |
Yeah, just slightly different: |
Hi,
related to the documentation PR #417, I'd like to motion to rename
WindowedApp
toGraphicalApp
.(I'm preparing a PR for this right now).
I'm open for comments and opinions about this.
PRO:
"win*"
configuration term to only match "windows" (or "win32", "winstore" etc), not "WindowedApp""vs*"
for targeting "windows" seems a bit hazarduous, as technically VS can use other compilers more freely these days. I.e. technically, I could want to create VS projects using another compiler (e.g. android-clang, or some console-specific one) (and changes for this could go mostly into a customized version of BX'stoolchain.lua
).CON:
sed
call couldn't fix).Regards.
The text was updated successfully, but these errors were encountered: