Feature/fix flaky tests #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r the whole test spec
…he expectation is in a function
…reports a warning otherwise
…reports a warning otherwise
caebr
approved these changes
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run test:watchführt die Tests im Headless aus - und startet sie wieder nach Änderungennpm run test:briefführt die Tests Headless im Watchmode aus - es werden aber nur die Tests die failen aufgelistet.Ich habe im Prinzip alle Warnings aus den logs geflickt - danach auch noch den Test wegen den MyUserSetttings - dort kam die Fehlermeldung eigentlich her - jetzt sollte es gut sein.
die
expect().nothing()habe ich ergänzt, weil Jasmine warnings ausgab, dass der Test keine Expectations enthalte - das ist dort der Fall wohttpTestingController.matchverwendet wird, oder die Expectation in eine Funktion ausgelagert ist.