Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

would be good to show small label (2-3 words) e.g. dylan python #10

Open
djay opened this issue Jul 27, 2017 · 3 comments
Open

would be good to show small label (2-3 words) e.g. dylan python #10

djay opened this issue Jul 27, 2017 · 3 comments

Comments

@djay
Copy link
Contributor

djay commented Jul 27, 2017

Show the first line (or first chars) below the image. People will get used to putting language/help wanted in that space. Perhaps even support hashtags?

@ches ches added the Feature label Aug 30, 2017
@ches
Copy link
Member

ches commented Aug 30, 2017

You guys may have discussed this earlier on and had good reasons for using one single GitHub issue as the backing data model for each event (pros and cons to the fact that everyone who adds a hack gets subscribed to the issue and gets email notifications for subsequent posts—kind of cool network effect of hearing about what others are doing, but also potentially annoyingly noisy to some). So forgive me if I'm ignorant of context.

But a thought that comes to mind—just putting the idea out there, haven't thoroughly thought it through—is that we could use a GitHub Milestone to represent each event, and create separate issues for each hack that get associated with the milestone of the event you're viewing. Event permalinks, #7, could facilitate making the association, and then issue numbers instead of comment IDs could be hack permalinks #18. The milestone description could hold the help text that is currently in the issue description of "main thread" issues like #12.

Getting around to the point… if the above proved a workable approach, issue labels could be used as the topic tags for this feature request. Possibly the API lets us get all the issue labels for a repo so we could do autocomplete on an input field which encourages people to reuse common existing labels like "javascript", "python", etc.

This could also open the possibility of users being able to comment on a particular hack in the hackmap UI to say "I want to join you!" and so forth.

@waf
Copy link
Member

waf commented Sep 28, 2017

@ches sorry for the late response. Thanks for thinking this through. I like the idea of supporting some sort of "I want to join you" feature.

The notification storm is both kind of cool and annoying. Perhaps the app could also call DELETE /notifications/threads/:id/subscription by default to remove the subscription. I've created issue #29 to track that.

For the datamodel aspect of it, we discussed this in slack, but just for public record and to spur conversation, I'm posting it here, too. We wanted a model that allows any github user to add their project to the hackmap, without requiring special permissions (e.g. needing to be added to a group). This reduces friction for the user and overhead for the organizers. I'm definitely open to alternative ways of storing the data.

@djay
Copy link
Contributor Author

djay commented Sep 26, 2018

@ches the problem with labels is that we can't set it so anyone can apply labels. Better to keep to hashtags or first line. More flexible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants