Add DYN_ARCH/USE_THREADS/USE_OPENMP features on linux #72
Conversation
|
This probably should be done together with #73. |
|
@cassiersg Hi, would you still like to rebase it? |
|
@Dirreke done |
| @@ -394,9 +394,11 @@ impl Configure { | |||
| } | |||
| if self.use_thread { | |||
| args.push("USE_THREAD=1".into()); | |||
| args.push("NUM_THREADS=256".into()); | |||
There was a problem hiding this comment.
I’m not certain if it’s necessary . After setting use_thread, will OpenBlas makefile script detect num_thread atomically?
| cfg.use_openmp = true; | ||
| } | ||
| if feature_enabled("dynamic_arch") { | ||
| cfg.no_shared = true; |
There was a problem hiding this comment.
I believe the variable name should be dynamic_arch. Additionally, please move these codes to line 145.
|
I'm unfortunately not using openblas anymore, and I barely remember why I did this PR. As for the Since I'm not able to help, I'm gonna close this PR and let anybody interested who has more time available finish that work. |
These features were supported by the build crate, but not exposed.
I picked a default value for NUM_THREADS when USE_THREADS is set, as I see no way to have this configured through features.
Close #106