Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model / custom node provisioning script #6

Closed
Dekita opened this issue Oct 13, 2023 · 5 comments
Closed

model / custom node provisioning script #6

Dekita opened this issue Oct 13, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@Dekita
Copy link
Contributor

Dekita commented Oct 13, 2023

If we could somehow define a 'provisioning' type script that allows for custom models etc to be added to the container image that'd be great! I seem to be having severe issues when trying to manually re-create the image locally :(

Perhaps something similar to the ai-dock runpod images (which is set via an env variable pointing to a github url where the prov script is, see the docker-compose for the project):
https://github.com/ai-dock/comfyui/tree/main/config/provisioning

edit: not really sure if this is possible for during the image build step, might still need to rebuild the image for custom models, but it'd be nice! :D

@TimPietrusky
Copy link
Member

TimPietrusky commented Oct 13, 2023

@Dekita It might be a good idea to introduce the network-volume for this case and connect this with Comfy, so that you can put any model you want into the volume and then those will be used instead of the ones that come with the image. See #1

How does this sound?

@TimPietrusky TimPietrusky self-assigned this Oct 13, 2023
@TimPietrusky TimPietrusky added the enhancement New feature or request label Oct 13, 2023
@Dekita
Copy link
Contributor Author

Dekita commented Oct 13, 2023

yea that sounds like it could work fine. end goal is just to be able to use custom models/loras/workflow nodes etc :)

@TimPietrusky
Copy link
Member

@Dekita then I will continue the work in #1 and if it works fine, we can close this one, ok?

@Dekita
Copy link
Contributor Author

Dekita commented Oct 14, 2023

yea thats fair, a network volume would likely help a lot for keeping the image size small too :)

@TimPietrusky
Copy link
Member

@Dekita thank you so much for all your input!

  • We decided to not provide a custom provisioning script, but keep it simple.
  • The network-volume was implemented with 2.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants