feat: Change addDependsOn to addDependency #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addDependsOn is deprecated: ``` ❯ yarn cdk synth info: Preparing App... [WARNING] aws-cdk-lib.CfnResource#addDependsOn is deprecated. use addDependency This API will be removed in the next major release. [WARNING] aws-cdk-lib.CfnResource#addDependsOn is deprecated. use addDependency This API will be removed in the next major release. ```
…o 2023-06-02/update-add-dependency-call
Signed-off-by: github-actions <github-actions@github.com>
blimmer
commented
Jun 3, 2023
| @@ -3,7 +3,7 @@ const { ReleaseTrigger } = require('projen/lib/release'); | |||
| const project = new awscdk.AwsCdkConstructLibrary({ | |||
| author: 'Ben Limmer', | |||
| authorAddress: 'https://benlimmer.com/freelance', | |||
| cdkVersion: '2.1.0', | |||
| cdkVersion: '2.56.0', | |||
There was a problem hiding this comment.
@hlascelles, since this project uses projen (https://projen.io/), you don't manually update package.json/yarn, etc. This is all managed through projen. I'm kind of surprised you were able to edit package.json, as projen marks those files as read-only.
So, with projen, to update anything, you handle it through this configuration file. When you make changes, you then run yarn projen, which updates all the dependent subfiles.
To produce this PR I:
- Checked out your branch.
- Discarded this commit where you updated the
package.json79111cd(#52) - Updated this
cdkVersionline in this file - Ran
yarn projen - Git add all and commit!
|
Thank you! 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an extension of #52 - cc @hlascelles
addDependsOn is deprecated:
❯ yarn cdk synth
info: Preparing App...
[WARNING] aws-cdk-lib.CfnResource#addDependsOn is deprecated.
use addDependency
This API will be removed in the next major release.
[WARNING] aws-cdk-lib.CfnResource#addDependsOn is deprecated.
use addDependency
This API will be removed in the next major release.