Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of contract types #50

Merged
merged 5 commits into from
Mar 29, 2022
Merged

List of contract types #50

merged 5 commits into from
Mar 29, 2022

Conversation

dangershony
Copy link
Member

image

@dangershony
Copy link
Member Author

image

@dangershony
Copy link
Member Author

Depends on block-core/blockcore-indexer#132

@dangershony
Copy link
Member Author

@miladsoft please review as well

Parental menus are not activated in the main menu
Copy link
Member

@sondreb sondreb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, there are a few minor points. There are some component variables that are unused, but that an issue in the whole codebase, I'll do a cleanup of that later.



if (this.daoContract.deposits) {
this.totalDepositsAmount = this.daoContract.deposits.map((item) => Number.parseInt(item.amount)).reduce((acc, curr) => acc + curr, 0);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll include "big.js" in the explorer soon and refactor these to use Big.

dangershony referenced this pull request in block-core/chaininfo Mar 29, 2022
@sondreb sondreb merged commit be5b765 into master Mar 29, 2022
@sondreb sondreb deleted the list-of-contracts branch March 29, 2022 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants