Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pvtpp_security_group should be named pvt_pp_security_group to stay consistent. #364

Closed
RSoulatIOHK opened this issue Sep 6, 2024 · 2 comments

Comments

@RSoulatIOHK
Copy link

All the pool voting thresholds are named pvt_xx except pvtpp_security_group.

pvtpp_security_group should be named pvt_pp_security_group to stay consistent with the rest of the naming.

@sorki
Copy link
Contributor

sorki commented Sep 11, 2024

Makes sense, we used the similar inconsistently named field from db-syncs schema

We will probably mark the pvtpp_security_group deprecated and a pvt_pp_security_group so it's backwards compatible.

@sorki
Copy link
Contributor

sorki commented Sep 11, 2024

Seems like it should be pvt_p_p_security_group as the others are like that (e.g. dvt_p_p_technical_group).

Naming is hard!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants