Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: is it possible to have several injected wallets displayed? #944

Closed
greedythib opened this issue Apr 13, 2022 · 9 comments
Closed
Assignees
Labels
feature New feature or request

Comments

@greedythib
Copy link

Is your request related to a problem?

Hi, currently only one injected wallet is displayed when connecting with onboard ->
Capture d’écran 2022-04-13 à 14 50 48

Is it possible to have several injected wallets displayed instead of one?

Thanks!

Feature Description

No response

Alternative Solutions

No response

Anything else?

No response

@greedythib greedythib added the feature New feature or request label Apr 13, 2022
@Adamj1232
Copy link
Member

Adamj1232 commented Apr 13, 2022

@greedythib which injected-wallets package version are you on? Which wallets are you wanting to show?
In the latest version of injected-wallets package, if a user has Coinbase wallet installed both CB and MM will be shown along with any others that are injected but this sharing of the window.ethereum space only works with Coinbase wallet installed currently. We are working with other wallet providers to move this direction.

@greedythib
Copy link
Author

@Adamj1232 I am using the very last versions for react and injected-wallets modules. OK thanks, indeed coinbase injected wallet is displayed separately from metamask, that's amazing!

However, it seems like await connect() does not trigger the connection when the array connectedWallets is empty. Do you know what it could be?

Thanks

@Adamj1232
Copy link
Member

@greedythib hmm Im not too sure, could you share a little more context around the code block causing an issue?
We have this working in our demo project here and I'm not seeing an issue when await connect() is called triggered and connectedWallets is empty

@greedythib
Copy link
Author

greedythib commented Apr 14, 2022

@Adamj1232 My code is exactly similar to the demo you mentioned. It was working smoothly but with the new updates, the call await connect() does not work anymore. I am not sure whether this is the reason but it is only triggering the connect modal when connectedWallets is not empty.

@Adamj1232
Copy link
Member

Adamj1232 commented Apr 14, 2022

@greedythib I would need more context around when await connect() is called to help as I do not see issues on my end

@Adamj1232
Copy link
Member

Adamj1232 commented Apr 14, 2022

@greedythib there is a new version of web3-onboard react out that I would recommend updating to and then comparing your code to the react demo code. I am going to close this issue as it is unrelated to the title but we can continue this discussion or I can meet you on discord for chat support which would be the easiest way to communicate

@enzoferey
Copy link
Contributor

enzoferey commented Sep 14, 2022

Hey @Adamj1232, sorry for bringing this back, but we are facing this issue where users that use Opera GX are only being suggested the Opera Wallet even though they have MetaMask installed on their browser. We would like both options to be suggested, is there any way of accomplishing that ?

@Adamj1232
Copy link
Member

@enzoferey we have a PR addressing that issue lined up here that will be published in the next couple days.

@enzoferey
Copy link
Contributor

Amazing thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants