Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not set error status for the whole transaction if internal transaction failed #4974

Closed
vbaranov opened this issue Dec 3, 2021 · 0 comments · Fixed by #5016
Closed

Do not set error status for the whole transaction if internal transaction failed #4974

vbaranov opened this issue Dec 3, 2021 · 0 comments · Fixed by #5016
Assignees
Labels
enhancement New feature or request

Comments

@vbaranov
Copy link
Member

vbaranov commented Dec 3, 2021

If an internal transaction has an error, do not apply this status to the whole transaction. Instead, display error status near corresponding internal transaction.

A current example of incorrect UX: https://blockscout.com/xdai/mainnet/tx/0x234f036d863a4da9a0a76cc128edfb492be2b77f7d6484e58bf5fb418f8a7b68

The whole transaction marked as reverted:

Screenshot 2021-12-03 at 21 08 26

Though that transaction was successful and only one internal transaction reverted according to: https://dashboard.tenderly.co/tx/xdai/0x234f036d863a4da9a0a76cc128edfb492be2b77f7d6484e58bf5fb418f8a7b68

Thus, if one of the internal transactions has an error and the whole transaction is successful:

  • We should remove an error status for the whole transaction transaction
  • Transaction tile should not be in red color. Add exclamation point icon with the hint "Error in Internal transaction":

Screenshot 2021-12-03 at 21 31 08

  • Whereas errored internal transaction tile should be in red color:

Screenshot 2021-12-03 at 21 16 38

@vbaranov vbaranov added the enhancement New feature or request label Dec 3, 2021
@nikitosing nikitosing self-assigned this Dec 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants