Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token icon image: add 50% border radius #1197

Closed
tom2drum opened this issue Sep 20, 2023 · 3 comments · Fixed by #1204
Closed

Token icon image: add 50% border radius #1197

tom2drum opened this issue Sep 20, 2023 · 3 comments · Fixed by #1204
Assignees
Labels
bug Something isn't working v1.12.0 Release v1.12.0

Comments

@tom2drum
Copy link
Collaborator

Since most of the imported images are circles, lets round up the token image container, to hide unnecessary backgrounds:

Now:
Image

->
To be:
Image

@tom2drum
Copy link
Collaborator Author

@NikitaSavik @tgladilina is this rule for all places where we display token icon or only for the page title? token icon placeholder should be rounded as well?

can we do these changes on mock-ups too then?

@tgladilina
Copy link
Collaborator

@NikitaSavik @tgladilina is this rule for all places where we display token icon or only for the page title? token icon placeholder should be rounded as well?

can we do these changes on mock-ups too then?

The original token icon can be any shape inside our frame with 2px corner radius without background

Screenshot 2023-09-20 at 17 14 57

@tom2drum tom2drum self-assigned this Sep 20, 2023
@tom2drum tom2drum added the bug Something isn't working label Sep 20, 2023
@tom2drum
Copy link
Collaborator Author

As discussed, we will change border-radius to full for all ERC-20 tokens logos. No changes are needed for the token placeholder and ERC-721 and ERC-1155 tokens logos.

@tom2drum tom2drum linked a pull request Sep 21, 2023 that will close this issue
@github-actions github-actions bot added pre-release Tasks in pre-release right now v1.12.0 Release v1.12.0 and removed pre-release Tasks in pre-release right now labels Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v1.12.0 Release v1.12.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants