Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change logos processing for marketplace dApps #1382

Closed
maikReal opened this issue Nov 30, 2023 · 2 comments · Fixed by #1392
Closed

Change logos processing for marketplace dApps #1382

maikReal opened this issue Nov 30, 2023 · 2 comments · Fixed by #1392
Assignees
Labels
marketplace Issues related to dApp marketplace v1.20.0 Release v1.20.0

Comments

@maikReal
Copy link
Collaborator

maikReal commented Nov 30, 2023

What to do?

Product epic: https://www.notion.so/blockscout/Fix-dApp-logo-displaying-771dcba7dec94b929ea0aa2728402735?pvs=4

  1. We need to add an auto-adding border radius for dApp logos. We can set border-radius to 8px, based on the following design

UPD [04.12]: The seconds point is not relevant
2. 1. For now we upload only one version of a dApp logo. It causes situations when one logo could look good on one theme, but weird on another one. My and @tgladilina idea is the following:
- For .png/.jpeg formats we can add white/dark border for logos
- For .svg format the algorithm is the following:
1. Checking the color of the logo on the border
2. If it's dark:
- On the dark theme: add white background
- On the light theme: do nothing
3. If it's light:
- On the dark theme: do nothing
- On the light theme: add dark background

@maikReal maikReal added the marketplace Issues related to dApp marketplace label Nov 30, 2023
@tgladilina
Copy link
Collaborator

Cases
Screenshot 2023-11-30 at 5 43 18 PM

@isstuev
Copy link
Collaborator

isstuev commented Dec 6, 2023

in fact, the task was to add 8px border radius to icons

@github-actions github-actions bot added pre-release Tasks in pre-release right now v1.20.0 Release v1.20.0 and removed pre-release Tasks in pre-release right now labels Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
marketplace Issues related to dApp marketplace v1.20.0 Release v1.20.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants