Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backward pagination doesn't work on direct links with page params #1388

Closed
yvaskov opened this issue Dec 4, 2023 · 2 comments · Fixed by #1409
Closed

Backward pagination doesn't work on direct links with page params #1388

yvaskov opened this issue Dec 4, 2023 · 2 comments · Fixed by #1409
Assignees
Labels
bug Something isn't working v1.21.0 Release v1.21.0

Comments

@yvaskov
Copy link
Contributor

yvaskov commented Dec 4, 2023

Description

'Prev page' navigation button doesn't become active after switching to the next page from direct link.

Image

Steps to reproduce

  1. Open https://eth.blockscout.com/token/0x16de9D750F4AC24226154C40980Ef83d4D3fD4AD?page=4&next_page_params=%257B%2522unique_token%2522%253A4900%257D
  2. Click on 'Next page' button

Actual result

User can't return from page 5 to 4, 6 to 5 and so on. 'Prev page' button is inactive.

Expected result

User is able to navigate back to the originally opened page (4 in the example above) from any of the following pages.

@yvaskov yvaskov added the bug Something isn't working label Dec 4, 2023
@isstuev isstuev self-assigned this Dec 7, 2023
@github-actions github-actions bot added the pre-release Tasks in pre-release right now label Dec 27, 2023
@0xtzData 0xtzData reopened this Jan 1, 2024
@isstuev
Copy link
Collaborator

isstuev commented Jan 1, 2024

it will not work on the 4th page in your example (we don't have prev page params), but if you navigate forward -- you will be able to navigate back (from 5th to 4th in your example.) that was the idea of the task

@isstuev isstuev closed this as completed Jan 1, 2024
@github-actions github-actions bot added v1.21.0 Release v1.21.0 and removed pre-release Tasks in pre-release right now labels Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v1.21.0 Release v1.21.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants