Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend analog of old UI HIDE_BLOCK_MINER env var #1395

Closed
vbaranov opened this issue Dec 6, 2023 · 1 comment · Fixed by #1397
Closed

Frontend analog of old UI HIDE_BLOCK_MINER env var #1395

vbaranov opened this issue Dec 6, 2023 · 1 comment · Fixed by #1397
Assignees
@tom2drum
Labels
enhancement New feature or request v1.20.0 Release v1.20.0

Comments

@vbaranov
Copy link
Member

vbaranov commented Dec 6, 2023 •
edited
Loading

Description

It should hide miner/validator field, if env var is provided.

Screenshot 2023-12-06 at 09 59 09

It should be also hidden in other subviews, where it is present.

Link to the page

https://www.shibariumscan.io/

Steps to reproduce

  1. Go to '...'
  2. Click on '...'
  3. Scroll down to '...'
  4. See error

App version

v1.18.1

Browser

No response

Operating system

None

Additional information

No response
@vbaranov vbaranov added bug Something isn't working triage Issues and PRs that are needed triage labels Dec 6, 2023
@tom2drum tom2drum added enhancement New feature or request and removed bug Something isn't working triage Issues and PRs that are needed triage labels Dec 6, 2023
@tom2drum tom2drum self-assigned this Dec 6, 2023
@tom2drum
Copy link
Collaborator

tom2drum commented Dec 6, 2023

the field can be hidden in all block views by providing variable NEXT_PUBLIC_VIEWS_BLOCK_HIDDEN_FIELDS=['miner']

@tom2drum tom2drum linked a pull request Dec 6, 2023 that will close this issue
Update SearchBar background color and hide miner field in block views #1397
Merged
@github-actions github-actions bot added pre-release Tasks in pre-release right now v1.20.0 Release v1.20.0 and removed pre-release Tasks in pre-release right now labels Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tom2drum tom2drum

Labels
enhancement New feature or request v1.20.0 Release v1.20.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update SearchBar background color and hide miner field in block views blockscout/frontend
2 participants
@vbaranov @tom2drum