fix: deserializing multisig txs

hirosystems · Aug 24, 2020 · db6d264 · db6d264
1 parent 34ba78c
commit db6d264
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 29 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -91,7 +91,7 @@
     "bitcoinjs-lib": "^5.1.7",
     "bluebird": "^3.7.2",
     "bn.js": "^4.11.8",
-    "c32check": "^1.0.1",
+    "c32check": "^1.1.2",
     "coinselect": "^3.1.12",
     "compression": "^1.7.4",
     "cors": "^2.8.5",

diff --git a/src/p2p/tx.ts b/src/p2p/tx.ts
@@ -70,6 +70,8 @@ interface TransactionSpendingConditionMultiSig {
   nonce: bigint; // u64
   feeRate: bigint; // u64
   authFields: TransactionAuthField[];
+  /** A 2-byte signature count indicating the number of signatures that are required for the authorization to be valid */
+  signatureCount: number; //u16
 }
 
 export enum TransactionAuthTypeID {
@@ -579,6 +581,7 @@ function readTransactionSpendingCondition(reader: BufferReader): TransactionSpen
       nonce: reader.readBigUInt64BE(),
       feeRate: reader.readBigUInt64BE(),
       authFields: new Array<TransactionAuthField>(reader.readUInt32BE()),
+      signatureCount: -1,
     };
     for (let i = 0; i < condition.authFields.length; i++) {
       const authType = reader.readUInt8Enum(TransactionAuthFieldTypeID, n => {
@@ -608,6 +611,7 @@ function readTransactionSpendingCondition(reader: BufferReader): TransactionSpen
         );
       }
     }
+    condition.signatureCount = reader.readUInt16BE();
     return condition;
   } else {
     throw new NotImplementedError(