Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept valid pool contract addresses for stacking #1165

Closed
friedger opened this issue Mar 21, 2023 · 3 comments
Closed

Accept valid pool contract addresses for stacking #1165

friedger opened this issue Mar 21, 2023 · 3 comments
Labels
Enhancement 💡 Functionality needed or wanted by users P2 Enhancement ⚡️ Critical functionality needed by few users, with no clear alternatives stacking stacking-delegation

Comments

@friedger
Copy link
Contributor

When typing a valid smart contract address as pool address it is rejected as invalid:

image
@friedger
Copy link
Contributor Author

The current pool address for Fast Pool is SP21YTSM60CAY6D011EZVEVNKXVW8FVZE198XEFFP.pox-fast-pool-v1

@markmhendrickson
Copy link
Collaborator

Any particular reason / advantage to using the contract here if we're not collecting BTC addresses?

@markmhendrickson markmhendrickson added Enhancement 💡 Functionality needed or wanted by users stacking stacking-delegation P2 Enhancement ⚡️ Critical functionality needed by few users, with no clear alternatives labels Mar 21, 2023
@markmhendrickson markmhendrickson changed the title Pool address rejected if it is a valid contract address Accept valid pool addresses for stacking Mar 21, 2023
@markmhendrickson markmhendrickson changed the title Accept valid pool addresses for stacking Accept valid pool contract addresses for stacking Mar 21, 2023
@friedger
Copy link
Contributor Author

@markmhx it is not about btc rewards but about the pool operator. That can be a stx address or a smart contract address. A principal.

friedger added a commit to friedger/stacks-wallet that referenced this issue Mar 22, 2023
@friedger
fix: accept contract addresses as pool address (leather-io#1165)
7c6e228
@friedger friedger mentioned this issue Mar 22, 2023
Closed
@github-project-automation github-project-automation bot moved this to Enhancements backlog in Hiro Wallet (DEPRECATED) Mar 23, 2023
@markmhendrickson markmhendrickson moved this from Enhancements backlog to Review in Hiro Wallet (DEPRECATED) Mar 23, 2023
@markmhendrickson markmhendrickson moved this from Review to Ready to release in Hiro Wallet (DEPRECATED) Mar 27, 2023
edu-stx pushed a commit that referenced this issue Mar 29, 2023
@friedger @edu-stx
fix: accept contract addresses as pool address (#1165)
67dcdf1
@edu-stx edu-stx closed this as completed Mar 29, 2023
blockstack-devops pushed a commit that referenced this issue Mar 29, 2023
@semantic-release-bot
chore(release): 4.8.0-dev.2
dcbba97 
# [4.8.0-dev.2](v4.8.0-dev.1...v4.8.0-dev.2) (2023-03-29)

### Bug Fixes

* accept contract addresses as pool address ([#1165](#1165)) ([67dcdf1](67dcdf1))
* ci gpg key import ([6948d92](6948d92))
* **sandbox:** prettier ([095bae9](095bae9))
@edu-stx edu-stx mentioned this issue Mar 30, 2023
Merged
blockstack-devops pushed a commit that referenced this issue Apr 3, 2023
@semantic-release-bot
chore(release): 4.9.0-dev.1
5d44f91 
# [4.9.0-dev.1](v4.8.0...v4.9.0-dev.1) (2023-04-03)

### Bug Fixes

* accept contract addresses as pool address ([#1165](#1165)) ([67dcdf1](67dcdf1))
* ci gpg key import ([6948d92](6948d92))
* **sandbox:** prettier ([095bae9](095bae9))
* typo ([a280c13](a280c13))
* update ci ([671f3c2](671f3c2))
* zero locked balance ([528b5bc](528b5bc))

### Features

* make our lives easier ([43fa4bd](43fa4bd))
* remove outdated messages ([c613724](c613724))
* update supported btc address formats ([0a8fd55](0a8fd55))
@fbwoolf fbwoolf moved this from Ready to release to Released in Hiro Wallet (DEPRECATED) Apr 6, 2023
@fbwoolf fbwoolf moved this from Released to Ready to release in Hiro Wallet (DEPRECATED) Apr 6, 2023
blockstack-devops pushed a commit that referenced this issue Apr 12, 2023
@semantic-release-bot
chore(release): 4.9.0
7b1b2d3 
# [4.9.0](v4.8.0...v4.9.0) (2023-04-12)

### Bug Fixes

* accept contract addresses as pool address ([#1165](#1165)) ([67dcdf1](67dcdf1))
* ci gpg key import ([6948d92](6948d92))
* **sandbox:** prettier ([095bae9](095bae9))
* typo ([a280c13](a280c13))
* update ci ([671f3c2](671f3c2))
* zero locked balance ([528b5bc](528b5bc))

### Features

* make our lives easier ([43fa4bd](43fa4bd))
* remove outdated messages ([c613724](c613724))
* update supported btc address formats ([0a8fd55](0a8fd55))
@markmhendrickson markmhendrickson moved this from Ready to release to Released in Hiro Wallet (DEPRECATED) Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement 💡 Functionality needed or wanted by users P2 Enhancement ⚡️ Critical functionality needed by few users, with no clear alternatives stacking stacking-delegation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: accept contract addresses as pool address (#1165) friedger/stacks-wallet
3 participants
@markmhendrickson @friedger @edu-stx