Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement notifications #37

Open
Benjozork opened this issue Feb 16, 2020 · 1 comment
Open

Implement notifications #37

Benjozork opened this issue Feb 16, 2020 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@Benjozork
Copy link
Collaborator

Self-explanatory. Could work via a WebSocket connection established at page load.

A possible architecture would be this :

  • Notification object, source: NotificationSource, target: User / targets: Set<User>
  • NotificationSource interface for Resource objects that can fire notifications, i.e. articles, comments ...
  • notify() function on User that stores the notification in DB and finds an open WS connection to notify connected clients for the particular user(s) (notifications sent to multiple users might exist in the future)
  • Fetch all notifications from DB on WS open ...

WIP. More details to be added, esp. in regard to supporting Actions i.e. REPLY that would fire notifications automatically when the Actions framework is implemented.

@Benjozork Benjozork added the enhancement New feature or request label Feb 16, 2020
@Benjozork Benjozork added this to the v0.4.0 milestone Feb 16, 2020
@Benjozork
Copy link
Collaborator Author

Somewhat stable in 078b6b0. Needs polish.

@Benjozork Benjozork modified the milestones: v0.4.0, v0.3.0 Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant