-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What is contributor workflow #93
Comments
This is related to #82 |
hi @ziloka , basically just write code, test it, and ensure the result passes code quality checks and all the tests. When a PR is created, some auto testing process will start, and other developers will help with code review. Make sure you have all the information needed in the PR description section, including what problem(s) you're solving, a few sentences about how you did it, and what other things should be noted or aware of. Just try to communicate, and everything will be all fine. :-) I'd be nice to have you joined! 🚀 |
Thank you |
Maybe we can remove For example, I notice the To reach this, update README (#85 ) and build a workflow depend on Poetry is indispensable. |
@hms5232 sure why not. It'd be awesome. |
I use this command in the root directory to test whatever I want. poetry run python -m proxybroker [args.. options.. etc] eg poetry run python -m proxybroker find --types HTTP HTTPS --lvl High --countries US --strict -l 10 Sometimes when I want to more information to debug I'll run it with the logging on debug poetry run python -m proxybroker --log DEBUG find --types HTTP HTTPS SOCKS4 SOCKS5 -l 10 what command do you run to test the cli? |
Here use pyenv, in combination of poetry pyenv local 3.11.6
poetry install
# run whatever command
poetry run python -m proxybroker find --types HTTP HTTPS SOCKS4 SOCKS5 -l 10 |
I'm not very experienced with python and I just did my first PR for this project. What is your developer workflow?
I usually just write my code, and run
pip install .
and test it.The text was updated successfully, but these errors were encountered: