SFRPG: don't use the ammotracker for starfinder

[SoxMax]

Starfinder handles its ammo consumption when attacks are generated. While consuming ammo after an attack is resolved is probably the better way even the base SFRPG ruleset consumes ammo at attack generation time.

For now I've added for the SFRPG ruleset to skip updating the onPostAttackResolve action.

[bmos]

The downside of this would be loosing the "has used all their ammo" chat message.

In 5e they have a decrementAmmo function. Maybe you can request this be added to SFRPG?

Until then, this fix seems like a reasonable solution.

[SoxMax]

I agree, I'd rather migrate the ammo calculations to post attacking as its feel bad to pick up your die to attack and be immediately deducted ammo even if you don't attack with that die.

As far as out of ammo goes though when you pick up an attack Starfinder will post a message in chat saying you don't have any/enough ammo and not let you actually get the die for the attack.

Once I'm done with my improvements to the Effect Builder I intend to come back to this to make the ammo consumption experience much smoother for Starfinder.

[SoxMax]

Oh also I don't actually have write access to this repo to merge this PR

I need to read my emails