Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let's try and get rid of these. Either via the config, or avoid needing them altogether. #487

Open
saeed6944 opened this issue Dec 14, 2024 · 1 comment
Open

Let's try and get rid of these. Either via the config, or avoid needing them altogether. #487

saeed6944 opened this issue Dec 14, 2024 · 1 comment

Comments

@saeed6944
Copy link

Let's try and get rid of these. Either via the config, or avoid needing them altogether.
I also feel like pad_logits should be inferrable via config.unpad_inputs and pad_logits_no_grad via config.unpad_no_grad.

I'm not sure what we should do with the sparse_prediction stuff.

Originally posted by @tomaarsen in huggingface/transformers#35158 (comment)
@saeed6944
Copy link
Author

Let's try and get rid of these. Either via the config, or avoid needing them altogether.
I also feel like pad_logits should be inferrable via config.unpad_inputs and pad_logits_no_grad via config.unpad_no_grad.

I'm not sure what we should do with the sparse_prediction stuff.

Originally posted by @tomaarsen in huggingface/transformers#35158 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@saeed6944