Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-dependencies #46

Open
jayvdb opened this issue Oct 24, 2022 · 3 comments
Open

dev-dependencies #46

jayvdb opened this issue Oct 24, 2022 · 3 comments

Comments

@jayvdb
Copy link

jayvdb commented Oct 24, 2022

This tool doesnt appear to remove unneeded dev-dependencies.
Is that feasible to perform, perhaps opt-in?
@bnjbvr
Copy link
Owner

bnjbvr commented Oct 24, 2022

Hi! Thanks for opening an issue, yeah it's likely possible to do. It would require a bit of fine-tuning the directories that are being searched: dev-dependencies may be used in tests/, benches/, and maybe a few others, while non dev-dependencies would not, as far as I know.
Do you want to try to take a stab at it?

@jayvdb
Copy link
Author

jayvdb commented Oct 24, 2022

Sure.

@jayvdb
Copy link
Author

jayvdb commented Oct 29, 2022

Actually, with OpenAPITools/openapi-generator#13835 merged, I don't have a reason to be trimming dev-dependencies, so I wont be working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jayvdb @bnjbvr