Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Map.prototype[ @@toStringTag ] #1229

Closed
HalidOdat opened this issue May 7, 2021 · 2 comments · Fixed by #1249
Closed

Implement Map.prototype[ @@toStringTag ] #1229

HalidOdat opened this issue May 7, 2021 · 2 comments · Fixed by #1249
Assignees
Labels
builtins PRs and Issues related to builtins/intrinsics E-Easy Easy enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@HalidOdat
Copy link
Member

ECMASCript feature

Implement Map.prototype[ @@toStringTag ], as a reference on how to implement it, you can check #1225 (Math[ @@toStringTag ]).

Example code
This code should now work and give the expected result:

let result = (new Map())[Symbol.toStringTag];

console.log(result);

The expected output is "Map".

@HalidOdat HalidOdat added enhancement New feature or request good first issue Good for newcomers E-Easy Easy builtins PRs and Issues related to builtins/intrinsics labels May 7, 2021
@wylie39
Copy link
Contributor

wylie39 commented May 12, 2021

Can I take a stab at this?

@HalidOdat
Copy link
Member Author

Can I take a stab at this?

Sure :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builtins PRs and Issues related to builtins/intrinsics E-Easy Easy enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants