Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Reflect[ @@toStringTag ] #1232

Closed
HalidOdat opened this issue May 7, 2021 · 3 comments · Fixed by #1033
Closed

Implement Reflect[ @@toStringTag ] #1232

HalidOdat opened this issue May 7, 2021 · 3 comments · Fixed by #1033
Labels
builtins PRs and Issues related to builtins/intrinsics E-Easy Easy enhancement New feature or request good first issue Good for newcomers
Milestone
v0.12.0

Comments

@HalidOdat
Copy link
Member

ECMASCript feature

Implement Reflect[ @@toStringTag ], as a reference on how to implement you can check #1225 (Math[ @@toStringTag ]).

Example code
This code should now work and give the expected result:

let result = Reflect[Symbol.toStringTag];

console.log(result);

The expected output is "Reflect".
@HalidOdat HalidOdat added enhancement New feature or request good first issue Good for newcomers E-Easy Easy builtins PRs and Issues related to builtins/intrinsics labels May 7, 2021
@HalidOdat
Copy link
Member Author

This is already implemented.

@Razican Razican added this to the v0.12.0 milestone May 10, 2021
@Razican
Copy link
Member

Razican commented May 10, 2021

We should probably link the PR in order to track when it was implemented.

@HalidOdat
Copy link
Member Author

We should probably link the PR in order to track when it was implemented.

It was implemented in #1033.

@Razican Razican linked a pull request May 10, 2021 that will close this issue
Implement Reflect built-in object #1033
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
builtins PRs and Issues related to builtins/intrinsics E-Easy Easy enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
v0.12.0
Development

Successfully merging a pull request may close this issue.

Implement Reflect built-in object
2 participants
@Razican @HalidOdat