Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make a pre-bytecode-compilation phase to analyze variable scopes #3490

Open
jedel1043 opened this issue Nov 29, 2023 · 2 comments
Open

Make a pre-bytecode-compilation phase to analyze variable scopes #3490

jedel1043 opened this issue Nov 29, 2023 · 2 comments
Labels
Internal Category for changelog performance Performance related changes and issues vm Issues and PRs related to the Boa Virtual Machine.

Comments

@jedel1043
Copy link
Member

This should help determine which variables are live at any moment, which will help on the implementation of #3194
@jedel1043 jedel1043 added performance Performance related changes and issues vm Issues and PRs related to the Boa Virtual Machine. Internal Category for changelog labels Nov 29, 2023
@jedel1043 jedel1043 mentioned this issue Nov 29, 2023
Closed
@raskad
Copy link
Member

raskad commented Sep 22, 2024

Instead of having an entire pre-parse stage, the scope analysis has been implemented on the AST in #3988.
I think pre-parsing is probably not our top priority, as our main performance optimization potential is in the execution time. I would be in favor of closing this.

@jedel1043
Copy link
Member Author

I think the title is just wrong 🤣
What I probably meant when opening this was a pre-bytecode-compiler phase, which the new AST changes definitely fit within

@jedel1043 jedel1043 changed the title Make a pre-parsing phase to analyze variable scopes Make a pre-bytecode-compilation phase to analyze variable scopes Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Internal Category for changelog performance Performance related changes and issues vm Issues and PRs related to the Boa Virtual Machine.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@raskad @jedel1043