Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global properties (Infnity, undefined, NaN) don't have the right attributes set #758

Closed
HalidOdat opened this issue Oct 2, 2020 · 0 comments · Fixed by #722
Closed

Global properties (Infnity, undefined, NaN) don't have the right attributes set #758

HalidOdat opened this issue Oct 2, 2020 · 0 comments · Fixed by #722
Assignees
@HalidOdat
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics Hacktoberfest Hacktoberfest 2021 - https://hacktoberfest.digitalocean.com
Milestone
v0.11.0

Comments

@HalidOdat
Copy link
Member

Describe the bug
The global properties don't have the correct attributes set like (Infnity, undefined, NaN) they should have
READONLY, NON_ENUMERABLE and PERANENT instead they have WRITABLE, ENUMERABLE, CONFIGURABLE

To Reproduce
Steps to reproduce the issue, or JavaScript code that causes this failure.

This JavaScript code reproduces the issue:

Infinity = 1 // this sets it to the value 1 but it should not change.
delete undefined // This deletes the global property
globalThis.propertyIsEnumerable("NaN") // gives true when it should be false
@HalidOdat HalidOdat added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics labels Oct 2, 2020
@HalidOdat HalidOdat added this to the v0.10.0 milestone Oct 2, 2020
@HalidOdat HalidOdat linked a pull request Oct 2, 2020 that will close this issue
ConstructorBuilder, ObjectInitializer, cache standard objects and fix global object attributes #722
Merged
@HalidOdat HalidOdat self-assigned this Oct 2, 2020
@HalidOdat HalidOdat added the Hacktoberfest Hacktoberfest 2021 - https://hacktoberfest.digitalocean.com label Oct 2, 2020
@RageKnify RageKnify modified the milestones: v0.10.0, v0.11.0 Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HalidOdat HalidOdat

Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics Hacktoberfest Hacktoberfest 2021 - https://hacktoberfest.digitalocean.com
Projects
None yet
Milestone
v0.11.0
2 participants
@HalidOdat @RageKnify