Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🕵🏻‍♂️ : Refactor with modal container with use of hook or context to show modal. #475

Closed
sk-enya opened this issue Apr 15, 2024 · 3 comments
Closed

🕵🏻‍♂️ : Refactor with modal container with use of hook or context to show modal. #475

sk-enya opened this issue Apr 15, 2024 · 3 comments
Assignees
@sk-enya

Comments

@sk-enya
Copy link
Collaborator

sk-enya commented Apr 15, 2024

Find out the better way to load the enabled modal and show it accordingly istead of multiple check of modal.
@sk-enya sk-enya self-assigned this Apr 15, 2024
@sk-enya
Copy link
Collaborator Author

sk-enya commented Apr 15, 2024

bobanetwork/boba_legacy#982 (comment)

@sk-enya
Copy link
Collaborator Author

sk-enya commented Apr 16, 2024

Also modal dispatch should have object as params instead of long list which is hard to remember values and it's usage.

@sk-enya
Copy link
Collaborator Author

sk-enya commented Jul 29, 2024

Closing as already handled!

@sk-enya sk-enya closed this as completed Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sk-enya sk-enya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sk-enya