Fix a bug in BTree get_next and get_prev search #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
changed the title
rphmeier
force-pushed
the
rh-fix-get-prev-next
branch
from
38409ed to
ab3a734
Compare
Previously, we weren't accounting for separator keys correctly in the recursive search. This commit fixes that and adds property tests.
rphmeier
force-pushed
the
rh-fix-get-prev-next
branch
from
ab3a734 to
5264a6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #215
Previously, we weren't accounting for separator keys correctly in the recursive search. This commit fixes that and adds property tests.
For example, if the root node had a separator with key
66and the right child node had keys[68, 69, 70, ...], a call tolookup_prev(67)would recurse into the child, find that there is nothing less than or equal to 67, and then bubble up aNonevalue all the way. The correct behavior is to return66from the parent node.The changeset here amends the search to return the previous separator when searching a child returns
None.