-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core.cache sessions may have a performance impact #2
Comments
I have created a namespace for performance comparison with the ring's default in-memory implementation. In summary, in the current version ( Looking at Anyway, of course that we should expect some overhead for the TTL session when comparing to the ring's default in-memory implementation. |
Yeah, I think some overhead is definitely to be expected, but would be nice if it could be within an order of magnitude at least. :) Otherwise, running a thread to do session cleanup is probably cheaper overall. |
Another idea might be to compare performance using Java cache libs like Guava cache. |
I made a project wrapping expiringmap Java lib here. It should be trivial to swap in for core.cache and see if it performs better. |
Thanks, @yogthos! I'll compare the performance using your lib today. I agree with you. In the worst case, providing an implementation that uses an additional thread for session cleanup could be a good alternative. |
By my last tests, expiring-map can be at most ~2x slower than the bare in-memory store in the worst case, which is a huge improvement over
|
This thread indicates that core.cache may be causing a significant performance hit. Might be worth investigating.
The text was updated successfully, but these errors were encountered: