Windows support #202
Merged
Windows support #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Not sure where it's coming from, since I use |
|
Weird that it was working on the other thread. Wondering what region is being passed. Try adding this and seeing what the region is set to: def client_options
return {} unless @info # aws_secret helper wont have @info
x = if @info['role_arn']
client_assume_role_options
else
client_default_options
end
puts "client_options:"
pp client_options
x
endThe terrraspace_plugin_aws uses the aws_data library to detect region here: https://github.com/boltops-tools/aws_data/blob/master/lib/aws_data.rb#L10 So that could be related. Maybe in the other terminal the AWS_REGION env was set. Though, still would like to fix the aws region detection either way. 👍 |
|
Nah, it's the same terminal, and no env var is used. I configured the default AWS profile. Not sure if your snippet is correct, because it goes in an endless loop on If I change it to: def client_options
return {} unless @info # aws_secret helper wont have @info
x = if @info['role_arn']
client_assume_role_options
else
client_default_options
end
puts "client_options:"
puts x
x
endIt prints |
|
To be sure, I changed the version in my local copy and ran So I'm on the correct branch for sure :) |
|
The incorrect region is coming from If I change it to I get: |
|
If I remove all ERB templates from |
|
So I think this PR can be merged as a way to support Windows, even without the ERB support right now (maybe a future fix?) 👍🏻 👍🏻 |
|
Merged. On the road now. Will release once get back to a computer. 💻 Note: For the error above. For some reason it looks like the ERB is not being rendered. Unsure. |
|
Yeah, looks like that. Thanks! Looking forward for the release :) |
|
Can you test again when you get a chance. This time on the master branch. Test with ERB. It was a simple fix in #203 Actually created the entire PR on my phone 📱while in the car 🚙 lol 🤣 |
Master works, with ERB :) 👍🏻 |
|
Released in 1.1.2 |
|
Awesome, thanks for the support! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a 🐞 bug fix.
This is a 🙋♂️ feature or enhancement.
bundle exec rspecto verify this)Summary
Add support for windows. Note: would like to test this some more but this seems to be enough to support windows.
Context
Related conversation #84
How to Test
Go through one of the getting started guides on Windows
https://terraspace.cloud/getting-started/
Version Changes
Patch