Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing semver dependency #2

Closed
kub1x opened this issue Mar 19, 2019 · 3 comments · Fixed by #4
Closed

Missing semver dependency #2

kub1x opened this issue Mar 19, 2019 · 3 comments · Fixed by #4
Labels

Comments

@kub1x
Copy link

kub1x commented Mar 19, 2019

The semver package is used, yet it is missing in dependencies field in package.json. This is an issue as it is probably a leaked dependency from mocha and causes it to fail to run when installed using pnpm.

@kub1x
Copy link
Author

kub1x commented Mar 20, 2019

Adding for reference the pnpmfile.js snippet to workaround this issue.

module.exports = { hooks: { readPackage } }

function readPackage (pkg) {
  switch (pkg.name) {
    case 'node-environment-flags':
      pkg.dependencies.semver = '*';
      break;
  }
  return pkg;
}

@SoyYoRafa
Copy link

SoyYoRafa commented Mar 30, 2019

Agreed. I sent a pull request.

@boneskull
Copy link
Owner

🎉 This issue has been resolved in version 1.0.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants