From e8c627bb094d2fb2231afe1eb0871cffa2688486 Mon Sep 17 00:00:00 2001 From: "Tim R. Bula" Date: Tue, 24 Jan 2023 12:34:38 -0600 Subject: [PATCH] fix: a bunch of visual defects --- .../CreateWorkflowContent.tsx | 11 ++- .../CreateWorkflowContent.tsx | 11 ++- .../ImportWorkflowContent.tsx | 6 +- .../EditTaskTemplateForm.tsx | 16 ++--- src/Components/LabelModal/LabelModal.tsx | 4 +- .../__snapshots__/PreviewConfig.spec.tsx.snap | 2 +- .../ScheduleManagerForm.tsx | 10 +-- .../SchedulePanelDetail.module.scss | 1 + .../SchedulePanelList.module.scss | 1 + .../TemplateConfigModalContent.tsx | 22 ++---- .../TemplateConfigModalContent.tsx | 4 +- src/Constants/index.ts | 6 +- .../ApproveRejectActions.module.scss | 14 ++-- .../ApproveRejectActions.tsx | 28 ++++---- src/Features/App/Navbar/Navbar.tsx | 4 +- .../ApproverGroupsTable.tsx | 6 -- .../CreateEditGroupModal.tsx | 36 ++++++---- .../CreateEditGroupModalContent.tsx | 2 +- .../createEditGroupModalContent.module.scss | 1 + src/Features/Editor/Configure/Configure.tsx | 60 ++++------------- .../ConfigureStorage/ConfigureStorage.tsx | 4 +- .../Configure/CreateToken/CreateToken.tsx | 2 +- .../Configure/CustomLabel/CustomLabel.tsx | 4 +- .../Editor/Configure/configure.module.scss | 10 ++- .../PropertiesModalContent.tsx | 8 +-- .../Editor/__snapshots__/Editor.spec.jsx.snap | 1 + .../TaskApprovalModal/TaskApprovalModal.tsx | 7 +- .../TaskApprovalModal.spec.jsx.snap | 11 +-- .../taskApprovalModal.module.scss | 9 --- .../TaskExecutionLog/TaskExecutionLog.tsx | 4 +- .../CreateEditPropertiesContent.tsx | 6 +- .../__snapshots__/Insights.spec.jsx.snap | 26 ++++--- .../ManageTeamTasks/Header/header.module.scss | 2 +- .../ManageTeamTasks/ManageTeamTasks.tsx | 35 ++++++++-- .../AddTaskTemplate/AddTaskTemplate.tsx | 2 +- .../AddTaskTemplateForm.tsx | 16 ++--- .../ManageTeamTasks/Sidenav/Sidenav.tsx | 67 ++++++++++++++----- .../taskTemplateOverview.module.scss | 3 +- .../taskTemplateYamlEditor.module.scss | 3 +- .../ManageTeamTasks/taskTemplates.module.scss | 2 +- .../QuotaEditModalContent.tsx | 2 +- .../Header/__snapshots__/Header.spec.jsx.snap | 2 +- .../TaskTemplates/Header/header.module.scss | 2 +- .../AddTaskTemplate/AddTaskTemplate.tsx | 2 +- .../AddTaskTemplateForm.tsx | 16 ++--- .../TaskTemplates/Sidenav/Sidenav.tsx | 1 + .../TaskTemplateOverview.spec.jsx.snap | 16 ++--- .../taskTemplateOverview.module.scss | 3 +- .../taskTemplateYamlEditor.module.scss | 3 +- .../__snapshots__/TaskTemplates.spec.tsx.snap | 5 +- .../TaskTemplates/taskTemplates.module.scss | 2 +- .../UpdateTeamName/UpdateTeamName.tsx | 2 +- .../CreateEditTeamPropertiesModalContent.tsx | 6 +- .../TeamPropertiesTable.tsx | 7 +- .../TeamPropertiesTable.spec.tsx.snap | 2 +- .../TeamProperties.spec.jsx.snap | 2 +- .../CreateToken/Form/index.tsx | 2 +- .../__snapshots__/index.spec.tsx.snap | 5 ++ .../TeamTokens/TeamTokenComponent/index.tsx | 10 ++- .../Teams/AddTeamContent/AddTeamContent.tsx | 2 +- .../CreateToken/Form/index.tsx | 6 +- .../DeleteToken/index.tsx | 2 +- .../__snapshots__/index.spec.tsx.snap | 5 ++ .../Tokens/GlobalTokenComponent/index.tsx | 2 + .../WorkflowQuotaModalContent.module.scss | 3 +- src/Features/Workflows/Workflows.tsx | 4 +- .../__snapshots__/Workflows.spec.jsx.snap | 4 +- src/Types/index.tsx | 10 +-- 68 files changed, 312 insertions(+), 283 deletions(-) diff --git a/src/Components/CreateTemplateWorkflow/CreateWorkflowContent/CreateWorkflowContent.tsx b/src/Components/CreateTemplateWorkflow/CreateWorkflowContent/CreateWorkflowContent.tsx index dc28727a2..215438883 100644 --- a/src/Components/CreateTemplateWorkflow/CreateWorkflowContent/CreateWorkflowContent.tsx +++ b/src/Components/CreateTemplateWorkflow/CreateWorkflowContent/CreateWorkflowContent.tsx @@ -155,9 +155,6 @@ const CreateWorkflowContent: React.FC = ({ placeholder="Select a team" invalid={teamError && teamTouched} invalidText="Team is required" - shouldFilterItem={({ item, inputValue }: { item: ComboBoxItem; inputValue: string }) => - item && item.name.toLowerCase().includes(inputValue.toLowerCase()) - } /> = ({ value={values.name} onBlur={handleBlur} onChange={handleChange} - invalid={errors.name && touched.name} + invalid={Boolean(errors.name && touched.name)} invalidText={errors.name} /> @@ -177,7 +174,7 @@ const CreateWorkflowContent: React.FC = ({ value={values.name} onBlur={handleBlur} onChange={handleChange} - invalid={errors.name && touched.name} + invalid={Boolean(errors.name && touched.name)} invalidText={errors.name} /> )} @@ -187,7 +184,7 @@ const CreateWorkflowContent: React.FC = ({ value={values.summary} onBlur={handleBlur} onChange={handleChange} - invalid={errors.summary && touched.summary} + invalid={Boolean(errors.summary && touched.summary)} invalidText={errors.summary} />