fix: check if property exists on object without executing #1560
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When populating the getters on a ReadModel, the getters are executed twice. Once where you would expect it, and once in an
if
statement to check if the property exists on the ReadModel. In thisif
statement, there is no check to see if the getter is a promise or not, so it is never awaited. When the getter-promise would eventually return an error, the whole Booster application crashes.This PR thus fixes two things:
Changes
Replaced
source[key] !== undefined
withkey in source
.Checks