Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gsoc2019] Add tests for adaptive thresholding #353

Open
mloskot opened this issue Jul 25, 2019 · 4 comments
Open

[gsoc2019] Add tests for adaptive thresholding #353

mloskot opened this issue Jul 25, 2019 · 4 comments
Assignees
Labels
core boost/gil good-first-issue Opportunity for new contributors to help improving GIL google-summer-of-code All items related to GSoC activities test New tests development or missing tests issues, no new functionality

Comments

@mloskot
Copy link
Member

mloskot commented Jul 25, 2019

@miralshah365 has submitted implementation of the algorithm in #341 with example-as-test, which has worked fine for development, but we need more complete test suite for it.

We need a basic variety of input images.

References

Test images options are being discused arranged:

@mloskot mloskot added core boost/gil test New tests development or missing tests issues, no new functionality labels Jul 25, 2019
@mloskot mloskot self-assigned this Jul 25, 2019
@mloskot mloskot added the google-summer-of-code All items related to GSoC activities label Feb 22, 2020
@manav-yb
Copy link

Is there any work to be still done on this issue?

@mloskot
Copy link
Member Author

mloskot commented Mar 12, 2020

AFAIK, yes, it an open issue and has not been targetted with any PR yet.

@mloskot mloskot added the good-first-issue Opportunity for new contributors to help improving GIL label Mar 12, 2020
@AdityaSanthosh
Copy link

@mloskot So, we basically need to upload more PNM files in this repo https://github.com/chhenning/gil_io_images/tree/master/pnm by creating them using ImageMagick if we're going with Julia kind of maintaining test Images in external Repo. Is there any script to download them into my local boost gil repo? If not, what does it take to create such a script that deploys test images directly into my boost gil test folder?

@mloskot
Copy link
Member Author

mloskot commented Jan 12, 2021

@AdityaSanthosh We maintain test images in this external repo under a GIL-dedicated organization https://github.com/boost-gil/test-images

Next, we need a script (i.e. two scripts, in Bash and PowerShell) that download the images from that repo into explicitly specified or automatically determined known location e.g. libs/gil/test/images).

Then, we need to

  • update the CI scripts to use those download scripts
  • modify tests to recognise the presence of the test images

Finally, we can get rid of any test images hosted in the Boost.GIL repo or at least any binary images and just keep the ASCII PNM but that will be possible after #359 is implemented.


Alternatively, we could Git submodule the test-images inside Boost.GIL repo, but I'm not convinced it is a good idea at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core boost/gil good-first-issue Opportunity for new contributors to help improving GIL google-summer-of-code All items related to GSoC activities test New tests development or missing tests issues, no new functionality
Projects
None yet
Development

No branches or pull requests

3 participants