Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ready for 1.78? #715

Closed
jzmaddock opened this issue Nov 2, 2021 · 16 comments
Closed

Ready for 1.78? #715

jzmaddock opened this issue Nov 2, 2021 · 16 comments

Comments

@jzmaddock
Copy link
Collaborator

Are there any show stoppers preventing a merge to master?

@NAThompson hows the cubic_roots_test now?

@jzmaddock
Copy link
Collaborator Author

@NAThompson
Copy link
Collaborator

@jzmaddock : Yup, my bad, will fix.

@NAThompson
Copy link
Collaborator

BTW why do we care if there's non-ASCII characters in comments? If appears that every compiler handles it just fine.

@jzmaddock
Copy link
Collaborator Author

BTW why do we care if there's non-ASCII characters in comments? If appears that every compiler handles it just fine.

Sorry no idea what the rationale was. I do know that users with far-eastern character sets can sometimes have all kinds of issues with non-ASCII characters, but I don't know the details....

@jzmaddock
Copy link
Collaborator Author

OK, since we're up against the beta deadline (tomorrow!), I've done a merge to master, if we can fix the remaining CI failures in beta though that would be great.

@NAThompson
Copy link
Collaborator

NAThompson commented Nov 3, 2021

@jzmaddock : Could you merge #716 for the beta?

@jzmaddock
Copy link
Collaborator Author

Could you merge #716 for the beta?

Yep, I'll let the CI play out a little longer first... we have a few hours yet and it's nearly run through...

@jzmaddock
Copy link
Collaborator Author

Can everyone please check that e000cf5#diff-f4da1e74afb45ab98ca3a2ad30842e21a37b13a5956514b904889f941100f83e covers the release notes for this release?

@NAThompson
Copy link
Collaborator

NAThompson commented Nov 5, 2021

@jzmaddock : Is there a spurious std::cout in tanh_sinh_detail in that commit?

Also appears no mention of the Bezier polynomial support.

@jzmaddock
Copy link
Collaborator Author

Is there a spurious std::cout in tanh_sinh_detail in that commit?

Aaah, reverted.

@ckormanyos
Copy link
Member

covers the release notes for this release?

Hi @jzmaddock

It's super trivial, but #507 has (think this is post-1.77):

  • Improve certain edge cases for <cstdfloat> complex-valued elementary functions.

Cc: @mborland and @NAThompson

@jzmaddock
Copy link
Collaborator Author

Also appears no mention of the Bezier polynomial support.

Done.

It's super trivial, but #507 has (think this is post-1.77):

Also now done.

@NAThompson
Copy link
Collaborator

Just read the docs for the cubic roots and for the Bezier polynomials, where are our new features for this release; they look good.

Note that these updates are only on develop, not yet on master; is that expected?

@jzmaddock
Copy link
Collaborator Author

Note that these updates are only on develop, not yet on master; is that expected?

The docs? I've only just added them and master is currently closed for the Beta, once it re-opens we can merge the doc changes, plus whatever we need to get our CI clean again.

@jzmaddock
Copy link
Collaborator Author

Hopefully this will green up CI: 40605d0

@jzmaddock
Copy link
Collaborator Author

Docs and history are merged, CI is green, closing down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants