Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failures in Boost.Math misc test suite #375

Closed
mborland opened this issue Oct 6, 2021 · 10 comments
Closed

Failures in Boost.Math misc test suite #375

mborland opened this issue Oct 6, 2021 · 10 comments

Comments

@mborland
Copy link
Member

mborland commented Oct 6, 2021

The quaternion tests are now failing using cpp_dec_float (see here). Looks to be an inexact comparison between a floating point type and an integer.

Bernoulli tests also now fail using cpp_bin_float as it registers as an unsupported configuration (see here).

@ckormanyos
Copy link
Member

quaternion tests are now failing using cpp_dec_float ... Looks to be an inexact comparison between a floating point...

Hi @mborland thenaks for finding this Matt!

Well, ... the fact that cpp_dec_float does not round has been present since the inception of cpp_dec_float.

Although this is not particularly nice, this behavior has not changed recently (although there is a completely separate, unmerged issue/branch related to this).

So I wonder what makes the difference in these tests now? Is it more exact knowledge or behavior of certain limbs when dealing with them within a constexpr context? Do we/I need to fundamentally change anything in cpp_dec_float? Or can we deal with that particular collection of test cases via tolerance increases?

Cc: @jzmaddock

@jzmaddock
Copy link
Collaborator

So I wonder what makes the difference in these tests now? Is it more exact knowledge or behavior of certain limbs when dealing with them within a constexpr context? Do we/I need to fundamentally change anything in cpp_dec_float? Or can we deal with that particular collection of test cases via tolerance increases?

I don't have time to debug this right now, but the failing tests really should have exact integer results IMO.

@jzmaddock
Copy link
Collaborator

Bernoulli tests also now fail using cpp_bin_float as it registers as an unsupported configuration (see here).

That's weird and rather perplexing, either I've made a mistake reconfiguring the Bernoulli code (but this did all pass I'm sure), or there's something up with . I might need to add an extra *info.cpp program to Boost.Config to probe the contents of so we can see what's up.

@ckormanyos
Copy link
Member

what makes the difference in these tests now?

the failing tests really should have exact integer results IMO

Yes. I will try to reproduce the behavior and go forward with debug.

@jzmaddock
Copy link
Collaborator

Aaaahh, the Bernoulli failure isn't a failure - it's a test that is expected not to compile and the actual test does pass.

@ckormanyos
Copy link
Member

ckormanyos commented Nov 2, 2021

Hi @mborland I believe @jzmaddock handled this by disabling a handful of cpp_dec_float tests in Boost.Math's miscsuite. See also math #712

Can we close?

@NAThompson
Copy link
Contributor

Aaaahh, the Bernoulli failure isn't a failure - it's a test that is expected not to compile and the actual test does pass.

I got burned by this one as well. Is there a way just to not print anything on expected failures?

@jzmaddock
Copy link
Collaborator

Yes!

@jzmaddock
Copy link
Collaborator

jzmaddock commented Nov 2, 2021

I got burned by this one as well. Is there a way just to not print anything on expected failures?

Not that I'm aware of. The trick when searching for failures is to always search for "..failed" or "\.\.failed" if this is a regex (grep etc).

@NAThompson
Copy link
Contributor

Ah I see. I always grepped for error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants