Include contents of symlinked directories in fileset #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Symlinked directories present in e.g. source-paths were previously ignored when building the fileset because the relevant tree-walking functions ignored links. By enabling them to follow symlinks, the contents of linked directories are now included in the fileset. Note that the symlinked directories are synced into "real" directories in the temp dir. For example, a symlink `foo` that points to a directory containing `bar.clj`, will be present in the temp dir as a *plain* directory `foo` containing `bar.clj`. So once these symlinked directories have been added to the fileset, they behave exactly as a plain directory would (because they are one). As a bonus, this means the change has no effect on any further temp dir related filesystem interaction (like scary deletion/cleanup that could interact with symlinks). Fixes boot-clj#481.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #481
I've included a snapshot version bump, but I can of course remove that if desired.