#359 - Modified aissemble-alerting-slack tests to run #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| </dependency> | ||
| <dependency> | ||
| <groupId>org.aeonbits.owner</groupId> | ||
| <artifactId>owner</artifactId> |
There was a problem hiding this comment.
Q/A: Was this added because we reference Owner classes via our usage of Krausening? If so, I think it probably makes more sense to just add Krausening and not Owner, as we'd probably not use Owner outside of Krausening.
There was a problem hiding this comment.
Yes it is and Krausening is already added as a dependency. I have removed the reference to the Owner classes.
| <dependency> | ||
| <groupId>junit</groupId> | ||
| <artifactId>junit</artifactId> | ||
| <version>${version.junit}</version> |
There was a problem hiding this comment.
S:
Suggested change
| <version>${version.junit}</version> | |
| <version>${version.junit}</version> | |
| <scope>test</scope> |
jacksondelametter
force-pushed
the
359-alerting-jdk17-upgrade
branch
from
ed529de to
a59e86d
Compare
ewilkins-csi
approved these changes
Oct 17, 2024
jacksondelametter
force-pushed
the
359-alerting-jdk17-upgrade
branch
from
248cf0a to
52353b7
Compare
…alerting pom files
jacksondelametter
force-pushed
the
359-alerting-jdk17-upgrade
branch
from
52353b7 to
ab48ac6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR is to verify the alerting modules are able to run with JDK 17. Fixed an issue with the extensions-alerting-slack module where the unit tests were not being ran on a build. Cleaned up unused dependencies and added transient dependency declarations in the pom files for the foundation-alerting, extensions-alerting, extensions-alerting-teams, and extensions-alerting-slack modules