Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade traefik client library to support new resource packaging #146

Closed
wants to merge 1 commit into from

Conversation

mya-crabnebula
Copy link

@mya-crabnebula mya-crabnebula commented Oct 12, 2023

Motivation

As it stands, Switchboard cannot work with newer versions of Traefik as describe in gh-111. This change patches the project to include the newer version of the Traefik client library allowing it to operate with newer versions of traefik.

Resolves #111

Explanation

This change upgrades the Traefik client library, patches the various files that use the Traefik, and finally updates the ClusterRole defined in the helm chart to support watching the appropriate resources.

Changes

  • Patches go.mod
  • Updates library usage
  • Updates the kubernetes controller permissions.

Checklist

  • I added relevant tests
  • I have updated the documentation if necessary

@Elegant996
Copy link

Yeah... This causes a problem because it forces everyone to switch to the new API. It's not really a fix in this case as it would quite literally break switchboard for everyone using the old API.

@borchero
Copy link
Owner

I will try working on this once the CI in this repo is fixed again (cf. #147). I can't replicate the failure locally, unfortunately, so this will likely take a bit of work.

@christian-vdz
Copy link
Contributor

christian-vdz commented Mar 19, 2024

Yeah... This causes a problem because it forces everyone to switch to the new API. It's not really a fix in this case as it would quite literally break switchboard for everyone using the old API.

Something has to be done, or switchboard will become unusable for all of us.
This should be released under a new major release (along with some dependency upgrades).

WYT?

@borchero
Copy link
Owner

I'd be very much in favor of updating. Unfortunately, I can't easily replicate the CI failure locally and I don't have too much time to look into this at the moment. @christian-vdz would you be able to investigate the failure? 🙏 once that is fixed, I think that we can move rather fast to upgrade everything.

@christian-vdz
Copy link
Contributor

@christian-vdz would you be able to investigate the failure? 🙏 once that is fixed, I think that we can move rather fast to upgrade everything.

Yes I can take some time to try and fix it.
Can you please allow workflows to run on this PR? #159

@borchero
Copy link
Owner

Closing in favor of #159.

@borchero borchero closed this Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for new API
4 participants