fix: improve caching for invoker and main path discovery #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the build phase would only install the invoker once. After this, if /workspace/.invoker directory was found, it would just assume the invoker was already there and skip it. A case where this could be a problem is if the invoker has been updated in the buildpack. Functions that have previously been built will skip installation of the new invoker. This change modifies the behavior so that the invoker itself is always installed. This is no problem with build time. It just copies two files. Then the package-lock.json checksum is used to determine if there has been a change, and if so, run npm ci again. Signed-off-by: Lance Ball <lball@redhat.com>
lance
added
runtime/nodejs
zroubalik
approved these changes
Jun 14, 2021
lkingland
approved these changes
Jun 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the build phase would only install the invoker once. After this,
if /workspace/.invoker directory was found, it would just assume the invoker
was already there and skip it.
A case where this could be a problem is if the invoker has been updated in
the buildpack. Functions that have previously been built will skip installation
of the new invoker.
This change modifies the behavior so that the invoker itself is always installed.
This is no problem with build time. It just copies two files. Then the
package-lock.json checksum is used to determine if there has been a change,
and if so, run npm ci again.
Signed-off-by: Lance Ball lball@redhat.com