Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add paginators for Application Auto Scaling service #1029

Merged
merged 1 commit into from
Sep 13, 2016
Merged

Add paginators for Application Auto Scaling service #1029

merged 1 commit into from
Sep 13, 2016

Conversation

ewbankkit
Copy link
Contributor

@codecov-io
Copy link

Current coverage is 97.57% (diff: 100%)

Merging #1029 into develop will not change coverage

@@            develop      #1029   diff @@
==========================================
  Files            44         44          
  Lines          6884       6884          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           6717       6717          
  Misses          167        167          
  Partials          0          0          

Powered by Codecov. Last update 40510b3...9915f78

@ewbankkit
Copy link
Contributor Author

Before:

$ python
Python 2.7.10 (default, Oct 23 2015, 19:19:21) 
[GCC 4.2.1 Compatible Apple LLVM 7.0.0 (clang-700.0.59.5)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import boto3
>>> session = boto3.Session()
>>> client = session.client('application-autoscaling')
>>> client.can_paginate('describe_scalable_targets')
False
>>> client.can_paginate('describe_scaling_activities')
False
>>> client.can_paginate('describe_scaling_policies')
False

after:

$ python
Python 2.7.10 (default, Oct 23 2015, 19:19:21) 
[GCC 4.2.1 Compatible Apple LLVM 7.0.0 (clang-700.0.59.5)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import boto3
>>> session = boto3.Session()
>>> client = session.client('application-autoscaling')
>>> client.can_paginate('describe_scalable_targets')
True
>>> client.can_paginate('describe_scaling_activities')
True
>>> client.can_paginate('describe_scaling_policies')
True
>>> paginator = client.get_paginator('describe_scalable_targets')
>>> paginator
<botocore.client.ApplicationAutoScaling.Paginator.DescribeScalableTargets object at 0x106ff6990>
>>> paginator = client.get_paginator('describe_scaling_activities')
>>> paginator
<botocore.client.ApplicationAutoScaling.Paginator.DescribeScalingActivities object at 0x1070692d0>
>>> paginator = client.get_paginator('describe_scaling_policies')
>>> paginator
<botocore.client.ApplicationAutoScaling.Paginator.DescribeScalingPolicies object at 0x107069150>

@jamesls
Copy link
Member

jamesls commented Sep 12, 2016

:shipit: Looks good to me.

@kyleknap
Copy link
Contributor

Looks good to me as well. 🚢

@kyleknap kyleknap added pr/ready-to-merge This PR is ready to be merged. and removed needs-additional-reviewer labels Sep 13, 2016
@jamesls jamesls merged commit 9915f78 into boto:develop Sep 13, 2016
@jamesls
Copy link
Member

jamesls commented Sep 13, 2016

Thanks for the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/ready-to-merge This PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants