Fix for EC2.Waiter.InstanceExists raising JMESPathTypeError #907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverted the "success" acceptor for that waiter to an earlier version that checks only the response code, not the response body. Added a unit test that reproduces the issue and passes with the change to the JSON file. Bug: #906
| @@ -7,9 +7,8 @@ | |||
| "operation": "DescribeInstances", | |||
| "acceptors": [ | |||
| { | |||
| "matcher": "path", | |||
| "expected": true, | |||
| "argument": "length(Reservations[]) > `0`", | |||
There was a problem hiding this comment.
I believe this was added because it's possible to get an empty reservations list even if you specify an instance id in some cases. I think we'll just need to modify the waiter code to handle this case appropriately.
|
I pulled in your PR and updated the code to only search non error responses. Closing in favor of #917 Thanks for the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverted the "success" acceptor for that waiter to an earlier version
that checks only the response code, not the response body.
Added a unit test that reproduces the issue and passes with the
change to the JSON file.
Bug: #906