-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kits: use an rpm package for bottlerocket licenses #3177
Comments
This is the other problematic file copy, it will be handled in a different issue: Line 386 in 63a5005
|
This was conflated with bootconfig files, which are now handled in #3187 . I have updated this to be about the license files only. |
This may want to be part of the kits milestone since rpm2img breaks if it doesn't have access to the Bottlerocket sourcecode repository (because it wants these license files) |
Description
The script,
rpm2img
assumes that we are running in the Bottlerocket monorepo.During the script execution it copies
LICENSE-MIT
directly from the git repo.This is problematic because an out-of-tree build may not have these files.
Instead, we should package licenses into an RPM file during the package build step and install them from the RPM package during rpm2img.
In other words, we can no longer do this:
bottlerocket/tools/rpm2img
Line 233 in 08497fd
Definition of Done
When the build no longer relies on Bottlerocket's license files being being present during rpm2img.
Related to #2669
The text was updated successfully, but these errors were encountered: