Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kits: use an rpm package for bottlerocket licenses #3177

Closed
webern opened this issue Jun 5, 2023 · 3 comments · Fixed by #3522
Closed

kits: use an rpm package for bottlerocket licenses #3177

webern opened this issue Jun 5, 2023 · 3 comments · Fixed by #3522
Labels
area/out-of-tree-builds Related to the efforts of making it easy to create builds outside of the main Bottlerocket repo

Comments

@webern
Copy link
Contributor

webern commented Jun 5, 2023

Description

The script, rpm2img assumes that we are running in the Bottlerocket monorepo.
During the script execution it copies LICENSE-MIT directly from the git repo.
This is problematic because an out-of-tree build may not have these files.

Instead, we should package licenses into an RPM file during the package build step and install them from the RPM package during rpm2img.

In other words, we can no longer do this:

install -p -m 0644 /host/{COPYRIGHT,LICENSE-APACHE,LICENSE-MIT} "${ROOT_MOUNT}"/usr/share/licenses/

Definition of Done

When the build no longer relies on Bottlerocket's license files being being present during rpm2img.

id: br_licenses
epic: twoliter_exec

Related to #2669

@webern webern added the area/out-of-tree-builds Related to the efforts of making it easy to create builds outside of the main Bottlerocket repo label Jun 5, 2023
@webern
Copy link
Contributor Author

webern commented Jun 5, 2023

This is the other problematic file copy, it will be handled in a different issue:

cp /host/tools/bootconfig/empty-bootconfig.data "${PRIVATE_MOUNT}/bootconfig.data"

@webern webern changed the title fix bottlerocket license file assumptions fix rpm2img local file assumptions Jun 5, 2023
@webern webern changed the title fix rpm2img local file assumptions use an rpm package for bottlerocket licenses Jun 8, 2023
@webern
Copy link
Contributor Author

webern commented Jun 8, 2023

This was conflated with bootconfig files, which are now handled in #3187 . I have updated this to be about the license files only.

@webern webern changed the title use an rpm package for bottlerocket licenses kits: use an rpm package for bottlerocket licenses Sep 19, 2023
@webern
Copy link
Contributor Author

webern commented Sep 19, 2023

This may want to be part of the kits milestone since rpm2img breaks if it doesn't have access to the Bottlerocket sourcecode repository (because it wants these license files)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/out-of-tree-builds Related to the efforts of making it easy to create builds outside of the main Bottlerocket repo
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant