Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slab geometry option #111

Open
johnomotani opened this issue Mar 24, 2020 · 0 comments
Open

slab geometry option #111

johnomotani opened this issue Mar 24, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@johnomotani
Copy link
Collaborator

It would be useful to have a geometry='slab' option, as well as the current 'toroidal' and 's-alpha'

Prompted by the discussion here #108 (comment).

'toroidal' should actually work for a slab, but it adds stuff that doesn't necessarily make sense. A simple slab probably just wants coordinates x = dx.isel(y=0).cumsum() - dx.isel(y=0)/2., y = dy.isel(x=0).cumsum() - dy.isel(x=0)/2., z = np.arange(0.5, nz)*dz. It can call _create_toroidal_regions() to create regions in case those are useful (although they should be fairly trivial).

To be implemented after #107 and #108 are merged.

@johnomotani johnomotani added the enhancement New feature or request label Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant