Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce simplify required dependencies #22

Closed
TomNicholas opened this issue Dec 8, 2018 · 3 comments
Closed

Reduce simplify required dependencies #22

TomNicholas opened this issue Dec 8, 2018 · 3 comments
Labels
requires xarray changes May require changes to xarray upstream to implement

Comments

@TomNicholas
Copy link
Collaborator

xarray and dask are obviously hard dependencies, but animatplot could be made optional by only importing it if you try to plot a gif, and natsort could possibly be eliminated by writing our own natural sorting function (instead of the call here).

xBOUT also currently depends on a specific fork of xarray, and this should be merged as soon as possible so that we can just have a dependency on the master version of xarray.

@TomNicholas TomNicholas added the requires xarray changes May require changes to xarray upstream to implement label Dec 8, 2018
@d7919
Copy link
Member

d7919 commented Dec 8, 2018

Agreed that minimising hard dependencies is a good idea. We should also watch out for dependencies that require very recent versions of other libraries as this can cause problems for users less familiar with upgrading packages.

@TomNicholas
Copy link
Collaborator Author

So my multi-dimensional auto-combine pull request has just been merged into the master branch of xarray, so we don't need to rely on my fork anymore.

It will be altered further in future (currently it's essentially a "hidden feature" as we haven't decided on the best way to restructure the API), but we will now always be able to use xarray's master branch (and the stable branch after they do their next release). @ZedThree perhaps you want to alter this in the setup.py?

@johnomotani
Copy link
Collaborator

I think we can close this now. We are compatible with released versions of xarray, and the pip/conda compatibility simplifies installing the few dependencies we do have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requires xarray changes May require changes to xarray upstream to implement
Projects
None yet
Development

No branches or pull requests

3 participants