Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bower does not update dependencies with branch as version #1242

Closed
JostBaron opened this issue Apr 13, 2014 · 9 comments
Closed

Bower does not update dependencies with branch as version #1242

JostBaron opened this issue Apr 13, 2014 · 9 comments
Labels

Comments

@JostBaron
Copy link

I have a git repository in my dependencies:

  "devDependencies": {
    "template": "user@domain.tld:reponame.git#develop"
  },

This should always fetch the newest version of the branch "develop" (when using bower update), but it doesn't. To get the newest version after someone pushed to it, I have to clean the bower cache, delete the directory in in my bower_components-folder, and do a bower update.

@mdasberg
Copy link
Contributor

It sees the that the commit hash has changed, but does not actually do anything with it :(

@sheerun
Copy link
Contributor

sheerun commented Apr 16, 2014

I can confirm. Bower updates package only after bower cache clean.

This is definitely connected with #1211 where overwriting cache were disabled. bower 1.3.1 is OK.

We should probably introduce --no-cache flag for such cases or disable caching of moving branches.

@benschwarz What do you think?

@sheerun sheerun added the bug label Apr 16, 2014
@sheerun sheerun changed the title Bower does not update git-dependencies to a branch if the branch has change Bower does not update dependencies with branch as version Apr 16, 2014
@benschwarz
Copy link
Member

I think a user calling bower update is explicit enough that they want to "fetch" remote repositories.
Why don't we remove the cache for bower update?

@sheerun
Copy link
Contributor

sheerun commented Apr 16, 2014

@benschwarz What cache? All cache or selectively? It is weird.

Besides as described in #1211 removing cache in any way produces lot of concurrency problems.

I think that entirely disabling cache for moving versions (like branches) is the best option.

@benschwarz
Copy link
Member

I think that entirely disabling cache for moving versions (like branches) is the best option.

👍

@MiguelMadero
Copy link

I think that entirely disabling cache for moving versions (like branches) is the best option.

👍

I'm having the same problem. Apart from bower cache clean is there another (better) workaround?

@sheerun
Copy link
Contributor

sheerun commented Apr 24, 2014

For now only downgrading to 1.3.1

@MiguelMadero
Copy link

Thanks. That sounds good.

@sheerun
Copy link
Contributor

sheerun commented Apr 24, 2014

Fixed on master. It'll be released in 1.3.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

5 participants